Repository navigation
OpenGP 1.0.5: latest names from mkgp2-decomp - #10
Merged
Merged
Conversation
GP 2 gets 869 more function names and 5,306 more data names from the decomp (now at db78988); 34 functions named earlier by signature matching or by older decomp names take the decomp's names (--rename-differing), and 48 objects are split into the decomp's named parts. GP 1 gets GP 2's names for the code the two share (539 functions, 1,192 objects) and the same corrections for the 27 renamed functions it shares. decompnames.py keeps a pair of objects only where its addresses are as far apart as the two releases are around it, and pairs objects left over by that distance: pairing by size slipped where one release merged or split objects the other did not. Addresses inside the decomp's names become this release's (names with one that is no symbol's are skipped), pad_/gap_ placeholders are skipped, and DECOMP_FIXES corrects GXGetCPUFifo. crossmatch.py no longer renames a label that shares a function's address, converts addresses inside names, and has --rename-differing too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This release pulls in the latest changes from mkgp2-decomp, the GP 2 decompilation (now at
db78988). Thank you to naari3 and everyone working on it!GX_SetNumTevStages->GXSetNumTexGens,dGeomDisable->sndConvertMs); GP 1 gets the same 27 it shares.DECOMP_FIXEScorrects the decomp's duplicateGXGetGPFifo(the first getter readsCPUFifo, so it isGXGetCPUFifo).Evidence
LastRead*/LastCommand*times, several vtables, message tables), 6 of them copied into GP 1, andcrossmatch.pyrenaming the labels__OSDBINTENDand__OSSystemCallVectorStartinstead of their functions.After: all of those are gone; the correct addresses the review gave now carry the names (
FlowSceneHost_vtable_804EBDF0,ChoiceChild_vtable_804EE200,LUT_Sine_rodata_802EDF60,kDateTextPos,LastReadFinished806D1A40 ...). No name in either game holds an address that is not one of its symbols; no new duplicate names; no hand-written PPC_FUNC/PPC_HOOK/recomp.toml name renamed.Merge Danger
Door: Two-way. Names only, plus 48 object splits; revert restores the previous lists. No save or link-protocol change.
Blast Radius: Recompile.
Generated code is regenerated for both games; the splits change jump-table bounds in GP 2. Hang reports and status backtraces show the new names. The decomp's names are its authors' reading of the code; most new data names say which part of the game the data belongs to rather than what it is.
🤖 Generated with Claude Code