Skip to content

OpenGP 1.0.5: latest names from mkgp2-decomp - #10

Merged
OfficiallySp merged 2 commits into
mainfrom
release-1.0.5
Nov 17, 2026
Merged

OfficiallySp merged 2 commits into
mainfrom
release-1.0.5

Conversation

@OfficiallySp

Copy link
Copy Markdown
Member

Summary

This release pulls in the latest changes from mkgp2-decomp, the GP 2 decompilation (now at db78988). Thank you to naari3 and everyone working on it!

mkgp2-decomp GNLJ82 symbols
  -> decompnames.py (--rename-differing)  -> games/mkgp2/config/symbols.txt
       functions: paired by size (unchanged)
       objects:   paired by size, kept only at the release distance around them,
                  leftovers paired by that distance; splits first
  -> crossmatch.py (--rename-differing)   -> games/mkgp1/config/symbols.txt
       identical code only; labels no longer renamed in place of functions
Functions named Data objects named
GP 2 3,427 -> 4,296 of 7,612 488 -> 5,794
GP 1 (from GP 2) 1,021 -> 1,560 77 -> 1,269
  • 34 GP 2 functions take the decomp's names (e.g. GX_SetNumTevStages -> GXSetNumTexGens, dGeomDisable -> sndConvertMs); GP 1 gets the same 27 it shares.
  • 48 GP 2 objects are split into the decomp's named parts, which changes the recompiled code slightly (jump tables are bounded by object size).
  • DECOMP_FIXES corrects the decomp's duplicate GXGetGPFifo (the first getter reads CPUFifo, so it is GXGetCPUFifo).
  • Version 1.0.5 and its changelog.

Evidence

  • Before: an independent review of the first import found about 41 GP 2 data names on the wrong object (size pairing slipped where the releases lay data out differently, e.g. the DVD LastRead*/LastCommand* times, several vtables, message tables), 6 of them copied into GP 1, and crossmatch.py renaming the labels __OSDBINTEND and __OSSystemCallVectorStart instead of their functions.
    After: all of those are gone; the correct addresses the review gave now carry the names (FlowSceneHost_vtable_804EBDF0, ChoiceChild_vtable_804EE200, LUT_Sine_rodata_802EDF60, kDateTextPos, LastReadFinished 806D1A40 ...). No name in either game holds an address that is not one of its symbols; no new duplicate names; no hand-written PPC_FUNC/PPC_HOOK/recomp.toml name renamed.
  • Re-running both tools on the result changes nothing (byte-identical files).
  • Windows clang-cl build of both games, CTest 22/22. Headless scripted runs: GP 2 through two Yoshi Cup races, GP 1 through a race to the Continue? screen; exit 0. Screenshots stay local (game-derived).
  • Only names, addresses, sizes and kinds changed in the symbol lists; no code or data bytes.

Merge Danger

Door: Two-way. Names only, plus 48 object splits; revert restores the previous lists. No save or link-protocol change.

Blast Radius: Recompile.

Generated code is regenerated for both games; the splits change jump-table bounds in GP 2. Hang reports and status backtraces show the new names. The decomp's names are its authors' reading of the code; most new data names say which part of the game the data belongs to rather than what it is.

🤖 Generated with Claude Code

OfficiallySp and others added 2 commits November 17, 2026 19:12
GP 2 gets 869 more function names and 5,306 more data names from the
decomp (now at db78988); 34 functions named earlier by signature matching
or by older decomp names take the decomp's names (--rename-differing),
and 48 objects are split into the decomp's named parts. GP 1 gets GP 2's
names for the code the two share (539 functions, 1,192 objects) and the
same corrections for the 27 renamed functions it shares.

decompnames.py keeps a pair of objects only where its addresses are as far
apart as the two releases are around it, and pairs objects left over by
that distance: pairing by size slipped where one release merged or split
objects the other did not. Addresses inside the decomp's names become this
release's (names with one that is no symbol's are skipped), pad_/gap_
placeholders are skipped, and DECOMP_FIXES corrects GXGetCPUFifo.
crossmatch.py no longer renames a label that shares a function's address,
converts addresses inside names, and has --rename-differing too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@OfficiallySp
OfficiallySp merged commit 8d343e9 into main Nov 17, 2026
6 checks passed
@OfficiallySp
OfficiallySp deleted the release-1.0.5 branch November 17, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant